Feat: upgrade1020 misc 2 #1532
Merged
Feat: upgrade1020 misc 2 #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustermeiszer
requested review from
mikiquantum,
NunoAlexandre,
hieronx,
wischli,
lemunozm and
cdamian
as code owners
|
This builds with |
|
/benchmark centrifuge |
|
/benchmark altair |
|
✅ Uploaded benchmarks for: |
|
/benchmark development |
|
✅ Uploaded benchmarks for: |
wischli
approved these changes
Sep 6, 2023
runtime/common/src/lib.rs
Outdated
Comment on lines
433
to
436
| pub type EnsureAccountOrRootOr<Account, O> = EitherOfDiverse< | ||
| EitherOfDiverse<EnsureSignedBy<AdminOnly<Account>, AccountId>, EnsureRoot<AccountId>>, | ||
| O, | ||
| >; |
There was a problem hiding this comment.
Nit: Couldn't we simplify this?
Suggested change
| pub type EnsureAccountOrRootOr<Account, O> = EitherOfDiverse< | |
| EitherOfDiverse<EnsureSignedBy<AdminOnly<Account>, AccountId>, EnsureRoot<AccountId>>, | |
| O, | |
| >; | |
| pub type EnsureAccountOrRootOr<Account, O> = EitherOfDiverse< | |
| EnsureAccountOrRoot<Account>, | |
| O, | |
| >; |
Comment on lines
+92
to
+98
| Weight::from_parts(78_019_565, 19974) | ||
| .saturating_add(Weight::from_ref_time(38_884_782).saturating_mul(N)) | ||
| .saturating_add(RocksDbWeight::get().reads(8)) | ||
| .saturating_add(RocksDbWeight::get().reads((7_u64).saturating_mul(N))) | ||
| .saturating_add(RocksDbWeight::get().writes(8)) | ||
| .saturating_add(RocksDbWeight::get().writes((6_u64).saturating_mul(N))) | ||
| .saturating_add(Weight::from_proof_size(17774).saturating_mul(N)) |
There was a problem hiding this comment.
Note: I made sure this default weight and PoV size for liquidity pool extrinsics is still executable. It is.
I do believe though we should increase it when we introduce foreign investments or did you factor that in already?
There was a problem hiding this comment.
No, I think we should increase it.
|
Integration tests and test go through locally I will merge that now. We can run final CI on feature branch then. |
mustermeiszer
added a commit
that referenced
this pull request
Sep 6, 2023
* wip xcm v3 asset-registry migrations * fix: xcm v3 altair, centrifuge * feat: add defensive SafeCallFilter for transact * clean up asset addition for catalyst & centrifuge * add Altair + Algol migration * Add Liquidity Pools related pallets to centrifuge runtime (#1523) * centrifuge: Add liquidity pools pallets to runtime * centrifuge: Add LP OutboundQueue wrapper to runtime * taplo: Obey * runtime: Move OutboundQueue import * centrifuge: Allow both root and half of council as admin origins for LP pallets * centrifuge: Add Axelar Gateway precompile * centrifuge: Use correct HRMP encoder, update HRMP fee to 1 DOT, use XCM V3 imports * centrifuge: Update error message for InboundQueue * clippy: Fix warnings * centrifuge: Rename outbound queue, fix migration import for orml asset registry * Upgrade1020 LP follow-ups (#1525) * centrifuge: Enable LP gateway XCM origin converter * centrifuge: Update LP pallet config to use Quantity for BalanceRatio * runtime: Update XCM origin converter, use Quantity in LP message, add OriginRecovery to LP gateway * feat: safe XCM version migration + extend SafeCallFilter (#1526) * fix: allow gateway process msg for xcm * feat: add safe xcm version migration * fix: Allow process_msg for xcm transact * refactor: remove spec_version check * refactor: stricter SafeCallFilter * Upgrade1020 LP follow-ups (#1525) * centrifuge: Enable LP gateway XCM origin converter * centrifuge: Update LP pallet config to use Quantity for BalanceRatio * runtime: Update XCM origin converter, use Quantity in LP message, add OriginRecovery to LP gateway * fix: rm OrderBook safe call cause missing * fix: OrderBook missing in both runtimes * fix: clippy --------- Co-authored-by: Cosmin Damian <[email protected]> * Feat/upgrade1020 misc 1 (#1529) * fix: asset metadata xcm v3 migration cleanup other migrations (#1528) * fix: centrifuge asset migration * Apply suggestions from code review Co-authored-by: Frederik Gartenmeister <[email protected]> * chore: append cfg assets to catalyst * fix: asset registry migration improvements * feat: apply asset metadata migration to altair runtime * fix: cleanup altair/algol migrations * fix: less aggressive nuke pre-upgrade * fix: finalize migrations, add context * fix: clippy + cleanup imports * fix: native currency altair, algol * fix: Algol native currency name --------- Co-authored-by: Frederik Gartenmeister <[email protected]> * fmt * fixup * Upgrade1020 gateway changes (#1531) * gateway: Use BoundedVec instead of EVMChain enum * gateway: Add Sender type to LP gateway config * gateway: Rename EVM chain size const, emit event when submitting message, adjust gateway sender provider * Feat: upgrade1020 misc 2 (#1532) * feat: account ensuring origin * feat: bumb runtime version develpment * fix: allow council to control gatway on Altair based chains * fix: use EnsureSigned, make use of type and add admin * feat: overestimated weights for lp logic * fix: taplooo * fix: tests and comment * chore: bump weights for 1020 (#1533) * chore: update centrifuge, altair weights * feat: bump and improve dev weights * fix: transfer_allowlist weights * feat: normalize SafeCallFilter across runtimes * fix: native asset key in migration --------- Co-authored-by: William Freudenberger <[email protected]> Co-authored-by: Cosmin Damian <[email protected]> Co-authored-by: Frederik Gartenmeister <[email protected]> Co-authored-by: nuno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Miscellaneous changes for the upgrade. Details see changes
Changes and Descriptions
EnsureAccoutOrRootOrstruct - allows to define an admin account for certain callsDevelopmentversion to10.21Checklist: